-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manually add triple slash directive to message-compiler
#1766
Merged
kazupon
merged 1 commit into
intlify:master
from
BobbieGoede:fix/triple-slash-directive-message-compiler
Mar 15, 2024
Merged
fix: manually add triple slash directive to message-compiler
#1766
kazupon
merged 1 commit into
intlify:master
from
BobbieGoede:fix/triple-slash-directive-message-compiler
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, It's really hacky 😅
Thanks!
I've checked it in my local!
LGTM!
Blankll
added a commit
to geek-fun/dockit
that referenced
this pull request
May 29, 2024
<p>This PR was automatically created by Snyk using the credentials of a real user.</p><br />![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade vue-i18n from 9.10.1 to 9.13.1.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **7 versions** ahead of your current version. - The recommended version was released on **a month ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>vue-i18n</b></summary> <ul> <li> <b>9.13.1</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.13.1">2024-04-20</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix(message-compiler): cannot resolve none-identifier characters at linked key by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2254557407" data-permission-text="Title is private" data-url="intlify/vue-i18n#1813" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1813/hovercard" href="https://github.com/intlify/vue-i18n/pull/1813">#1813</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.13.0...v9.13.1"><tt>v9.13.0...v9.13.1</tt></a></p> </li> <li> <b>9.13.0</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.13.0">2024-04-17</a></br> <h2>What's Changed</h2> <h3><g-emoji class="g-emoji" alias="warning">⚠️ </g-emoji> Deprecated Features</h3> <ul> <li>fix: EOL announcement warning for vue-i18n-bridge by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2242126147" data-permission-text="Title is private" data-url="intlify/vue-i18n#1800" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1800/hovercard" href="https://github.com/intlify/vue-i18n/pull/1800">#1800</a></li> </ul> <h3>⚡ Improvement Features</h3> <ul> <li>fix: not throw warnings when using implicit fallback by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ShinnosukeKomiya/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ShinnosukeKomiya">@ ShinnosukeKomiya</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2241461861" data-permission-text="Title is private" data-url="intlify/vue-i18n#1798" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1798/hovercard" href="https://github.com/intlify/vue-i18n/pull/1798">#1798</a></li> </ul> <h3>📝️ Documentations</h3> <ul> <li>fix: spelling by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/DamageESP/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/DamageESP">@ DamageESP</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243906945" data-permission-text="Title is private" data-url="intlify/vue-i18n#1802" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1802/hovercard" href="https://github.com/intlify/vue-i18n/pull/1802">#1802</a></li> <li>docs: improve documentation by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243065490" data-permission-text="Title is private" data-url="intlify/vue-i18n#1801" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1801/hovercard" href="https://github.com/intlify/vue-i18n/pull/1801">#1801</a></li> <li>docs: fix dead link on menu by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2246334568" data-permission-text="Title is private" data-url="intlify/vue-i18n#1804" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1804/hovercard" href="https://github.com/intlify/vue-i18n/pull/1804">#1804</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ShinnosukeKomiya/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ShinnosukeKomiya">@ ShinnosukeKomiya</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2241461861" data-permission-text="Title is private" data-url="intlify/vue-i18n#1798" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1798/hovercard" href="https://github.com/intlify/vue-i18n/pull/1798">#1798</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/DamageESP/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/DamageESP">@ DamageESP</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243906945" data-permission-text="Title is private" data-url="intlify/vue-i18n#1802" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1802/hovercard" href="https://github.com/intlify/vue-i18n/pull/1802">#1802</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.12.1...v9.13.0"><tt>v9.12.1...v9.13.0</tt></a></p> </li> <li> <b>9.12.1</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.12.1">2024-04-14</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: compile error for key with included hyphen in named interpolation by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2241445373" data-permission-text="Title is private" data-url="intlify/vue-i18n#1797" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1797/hovercard" href="https://github.com/intlify/vue-i18n/pull/1797">#1797</a></li> </ul> <h3>👕 Refactoring</h3> <ul> <li>refactor: tokenizer by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2241552649" data-permission-text="Title is private" data-url="intlify/vue-i18n#1799" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1799/hovercard" href="https://github.com/intlify/vue-i18n/pull/1799">#1799</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.12.0...v9.12.1"><tt>v9.12.0...v9.12.1</tt></a></p> </li> <li> <b>9.12.0</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.12.0">2024-04-12</a></br> <h2>What's Changed</h2> <h3>🌟 Features</h3> <ul> <li>fix: deprecate named interpolation with modulo syntax by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2238848229" data-permission-text="Title is private" data-url="intlify/vue-i18n#1795" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1795/hovercard" href="https://github.com/intlify/vue-i18n/pull/1795">#1795</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.11.1...v9.12.0"><tt>v9.11.1...v9.12.0</tt></a></p> </li> <li> <b>9.11.1</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.11.1">2024-04-10</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: regression triple slash including in <code>.d.ts</code> by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2234779004" data-permission-text="Title is private" data-url="intlify/vue-i18n#1794" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1794/hovercard" href="https://github.com/intlify/vue-i18n/pull/1794">#1794</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.11.0...v9.11.1"><tt>v9.11.0...v9.11.1</tt></a></p> </li> <li> <b>9.11.0</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.11.0">2024-04-04</a></br> <h2>What's Changed</h2> <h3>🌟 Features</h3> <ul> <li>fix: number and date format components not using <code>scope</code> prop by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/BobbieGoede/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/BobbieGoede">@ BobbieGoede</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2223851951" data-permission-text="Title is private" data-url="intlify/vue-i18n#1786" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1786/hovercard" href="https://github.com/intlify/vue-i18n/pull/1786">#1786</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/xuanzhi33/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/xuanzhi33">@ xuanzhi33</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2194120678" data-permission-text="Title is private" data-url="intlify/vue-i18n#1767" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1767/hovercard" href="https://github.com/intlify/vue-i18n/pull/1767">#1767</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/YoshiYo/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/YoshiYo">@ YoshiYo</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2220067795" data-permission-text="Title is private" data-url="intlify/vue-i18n#1781" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1781/hovercard" href="https://github.com/intlify/vue-i18n/pull/1781">#1781</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.10.2...v9.11.0"><tt>v9.10.2...v9.11.0</tt></a></p> </li> <li> <b>9.10.2</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.10.2">2024-03-15</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: manually add triple slash directive to <code>message-compiler</code> by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/BobbieGoede/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/BobbieGoede">@ BobbieGoede</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2188206916" data-permission-text="Title is private" data-url="intlify/vue-i18n#1766" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1766/hovercard" href="https://github.com/intlify/vue-i18n/pull/1766">#1766</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/shinGangan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/shinGangan">@ shinGangan</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2177198964" data-permission-text="Title is private" data-url="intlify/vue-i18n#1763" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1763/hovercard" href="https://github.com/intlify/vue-i18n/pull/1763">#1763</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.10.1...v9.10.2"><tt>v9.10.1...v9.10.2</tt></a></p> </li> <li> <b>9.10.1</b> - <a href="https://github.com/intlify/vue-i18n/releases/tag/v9.10.1">2024-03-01</a></br> <h2>What's Changed</h2> <h3>⚡ Improvement Features</h3> <ul> <li>chore(fix): <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1977884644" data-permission-text="Title is private" data-url="intlify/vue-i18n#1630" data-hovercard-type="issue" data-hovercard-url="/intlify/vue-i18n/issues/1630/hovercard" href="https://github.com/intlify/vue-i18n/issues/1630">#1630</a> make the install function synchronous to be aligned… by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/k-paxian/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/k-paxian">@ k-paxian</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1977894436" data-permission-text="Title is private" data-url="intlify/vue-i18n#1631" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1631/hovercard" href="https://github.com/intlify/vue-i18n/pull/1631">#1631</a></li> </ul> <h3>📝️ Documentations</h3> <ul> <li>docs: wrong te docs by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2162382013" data-permission-text="Title is private" data-url="intlify/vue-i18n#1753" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1753/hovercard" href="https://github.com/intlify/vue-i18n/pull/1753">#1753</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/k-paxian/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/k-paxian">@ k-paxian</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1977894436" data-permission-text="Title is private" data-url="intlify/vue-i18n#1631" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1631/hovercard" href="https://github.com/intlify/vue-i18n/pull/1631">#1631</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/intlify/vue-i18n/compare/v9.10.0...v9.10.1"><tt>v9.10.0...v9.10.1</tt></a></p> </li> </ul> from <a href="https://github.com/intlify/vue-i18n-next/releases">vue-i18n GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyZDk0ZTc3Yy1hZDAxLTRiZGQtOTUyYy01MzgwZmRjNTExYTEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjJkOTRlNzdjLWFkMDEtNGJkZC05NTJjLTUzODBmZGM1MTFhMSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?pkg=vue-i18n&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) <!--- (snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"vue-i18n","from":"9.10.1","to":"9.13.1"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"2d94e77c-ad01-4bdd-952c-5380fdc511a1","prPublicId":"2d94e77c-ad01-4bdd-952c-5380fdc511a1","packageManager":"npm","priorityScoreList":[],"projectPublicId":"d19c39b4-9b25-4232-b09a-2d71e94c8a24","projectUrl":"https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":7,"publishedDate":"2024-04-20T15:30:23.860Z"},"vulns":[]}) ---> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1760 (tested locally using the provided reproduction)
Not sure if this would cause other issues, I haven't tested this in more projects.
After spending some time trying to figure out why the triple slash directive is being added, I gave up. The actual problem in #1760 is the path inside the directive, so after adding one manually I found out that this removes the directive from the build (huh?).