Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tm function should accept DefineLocaleMessage key type #2014

Merged

Conversation

BobbieGoede
Copy link
Member

It looks like the $tm function on ComponentCustomProperties does not use the DefineLocaleMessage type for the key parameter. This is a simple copy paste of the type parameters used for $t, which I think should be the same for the keys.

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@intlify/core

pnpm add https://pkg.pr.new/@intlify/core@2014

@intlify/devtools-types

pnpm add https://pkg.pr.new/@intlify/devtools-types@2014

@intlify/core-base

pnpm add https://pkg.pr.new/@intlify/core-base@2014

petite-vue-i18n

pnpm add https://pkg.pr.new/petite-vue-i18n@2014

@intlify/shared

pnpm add https://pkg.pr.new/@intlify/shared@2014

@intlify/message-compiler

pnpm add https://pkg.pr.new/@intlify/message-compiler@2014

vue-i18n

pnpm add https://pkg.pr.new/vue-i18n@2014

@intlify/vue-i18n-core

pnpm add https://pkg.pr.new/@intlify/vue-i18n-core@2014

commit: 6e608fe

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Nov 14, 2024
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💚

@kazupon kazupon merged commit ea528c4 into intlify:master Nov 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants