add kafka eventbus spec #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com>
dfarr
requested changes
Jan 18, 2023
| @@ -57,3 +57,10 @@ data: | |||
| metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1 | |||
| configReloaderImage: natsio/nats-server-config-reloader:0.7.0 | |||
| startCommand: /nats-server | |||
| kafka: | |||
| streamConfig: | | |||
| # The default properties of the streams to be created in this Kafka service | |||
There was a problem hiding this comment.
Suggested change
| # The default properties of the streams to be created in this Kafka service | |
| # Default Kafka settings, can be overridden by EventBus Kafka specs |
There was a problem hiding this comment.
Just changing this to align with the jetstream comment
There was a problem hiding this comment.
that's for the settings of jetstream.. jetstream's stream config have this one "# The default properties of the streams to be created in this JetStream service" thats already in sync..
but i still feel it need to be rephrased
manifests/install.yaml
Outdated
| @@ -351,6 +351,13 @@ data: | |||
| metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1 | |||
| configReloaderImage: natsio/nats-server-config-reloader:0.7.0 | |||
| startCommand: /nats-server | |||
| kafka: | |||
| streamConfig: | | |||
| # The default properties of the streams to be created in this Kafka service | |||
There was a problem hiding this comment.
Suggested change
| # The default properties of the streams to be created in this Kafka service | |
| # Default Kafka settings, can be overridden by EventBus Kafka specs |
manifests/namespace-install.yaml
Outdated
| @@ -271,6 +271,13 @@ data: | |||
| metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1 | |||
| configReloaderImage: natsio/nats-server-config-reloader:0.7.0 | |||
| startCommand: /nats-server | |||
| kafka: | |||
| streamConfig: | | |||
| # The default properties of the streams to be created in this Kafka service | |||
There was a problem hiding this comment.
Suggested change
| # The default properties of the streams to be created in this Kafka service | |
| # Default Kafka settings, can be overridden by EventBus Kafka specs |
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com>
dfarr
pushed a commit
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 2, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
dfarr
pushed a commit
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Prema devi Kuppuswamy <premadk@gmail.com> Signed-off-by: David Farr <david_farr@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prema devi Kuppuswamy premadk@gmail.com
Checklist: