Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version in config #19

Merged
merged 1 commit into from
Feb 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions api/event-bus.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 11 additions & 14 deletions api/event-bus.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions api/jsonschema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,6 @@
"$ref": "#/definitions/io.argoproj.common.SASLConfig",
"description": "SASL configuration for the kafka client"
},
"streamConfig": {
"description": "Optional configuration for the kafka, if specified, it will be merged with the default configuration in controller-config. It accepts a YAML format configuration, available fields include, \"maxRetry\", \"configVersion (sarama config version)\", \"requiredAcks\", \"replication\".",
"type": "string"
},
"tls": {
"$ref": "#/definitions/io.argoproj.common.TLSConfig",
"description": "TLS configuration for the kafka client."
Expand All @@ -562,6 +558,10 @@
"url": {
"description": "URL to kafka cluster, multiple URLs separated by comma",
"type": "string"
},
"version": {
"description": "Kafka version, sarama defaults to the oldest supported stable version",
"type": "string"
}
},
"type": "object"
Expand Down
8 changes: 4 additions & 4 deletions api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

346 changes: 173 additions & 173 deletions pkg/apis/eventbus/v1alpha1/generated.pb.go

Large diffs are not rendered by default.

19 changes: 9 additions & 10 deletions pkg/apis/eventbus/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/eventbus/v1alpha1/kafka_eventbus.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type KafkaConfig struct {
URL string `json:"url,omitempty" protobuf:"bytes,1,opt,name=url"`
// Kafka version, sarama defaults to the oldest supported stable version
// +optional
Version string `json:"url,omitempty" protobuf:"bytes,2,opt,name=version"`
Version string `json:"version,omitempty" protobuf:"bytes,2,opt,name=version"`
// Topic name, defaults to namespace_name.eventbus_name
// +optional
Topic string `json:"topic,omitempty" protobuf:"bytes,3,opt,name=topic"`
Expand Down
14 changes: 7 additions & 7 deletions pkg/apis/eventbus/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.