add useVersion support to npm changelog #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds300
commented
Mar 23, 2023
| const title = `v${inc(lernaPackage.version, bump as ReleaseType)}`; | ||
| const title = `v${ | ||
| useVersion || inc(lernaPackage.version, bump as ReleaseType) | ||
| }`; |
There was a problem hiding this comment.
this is the only semantic change in this file, everything else was prettier
hipstersmoothie
approved these changes
Apr 3, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
I added the
useVersionoverride parameter to the changelog lifecycle events so that changelogs can be compiled with the same version number as the packages themselves. I also made the npm plugin respect this option.Why
At the moment, if I pass
useVersionit is used successfully when doing versioning and publishing but not when compiling the changelog, which ignores the override and uses the regular bumped version.Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor