Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing & Sizing Updates (Tree, Table, Nav) #12

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Spacing & Sizing Updates (Tree, Table, Nav) #12

merged 5 commits into from
Feb 16, 2021

Conversation

tylerkrupicka
Copy link
Contributor

@tylerkrupicka tylerkrupicka commented Feb 16, 2021 •
edited
Loading

What Changed

A number of fixes for minor spacing, themes, and resizing issues.

  • Fix the spacing of the Tree arrow, which was misaligned when placed next to non-arrow tree elements.
  • Fix the font sizing in Table, make it scale properly.
  • Fix the font sizing in Navigation, make it scale properly.
  • Fix the background and text color for themes in Navigation.

Why

What might be impacted

Todo:

  • Add tests
  • Add docs

@tylerkrupicka tylerkrupicka added the patch Patch version change label Feb 16, 2021
@tylerkrupicka tylerkrupicka changed the title Tree spacing & Sizing Updates Spacing & Sizing Updates (Tree, Table, Nav) Feb 16, 2021
@tylerkrupicka tylerkrupicka merged commit 0a1bb03 into intuit:master Feb 16, 2021
@tylerkrupicka tylerkrupicka deleted the tree-spacing branch February 16, 2021 07:00
@tylerkrupicka
Copy link
Contributor Author

🚀 PR was released in v1.0.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adierkens adierkens Awaiting requested review from adierkens adierkens is a code owner

Assignees
No one assigned
Labels
patch Patch version change released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tylerkrupicka