Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
I noticed the size of some of the components was pretty large, and did some digging to find out why. It turns out our package template is missing the sideEffects tag, so dependencies were never being tree-shaken.
This meant that:
@design-systems/theme
was never tree shaking based on usage.Breaking that apart and adding
sideEffects
dropped the size of the components, but there are still a couple issues remaining.Webpack is pulling in a
buffer
polyfill that is huge, probably because the Object value and parser reference the typeBuffer
. I think this might just be something to change in thesize
command webpack config but I need to check.The last optimization would be to just directly pull in the regex we need to detect firefox, so we don't need a full UA parser.