Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Adds on to #22.
The
table
component now supports a sticky header when scrolling, mirroring the behavior in the network panel.I moved to my own PR because I had to fix the resize observer logic, because it was reserving extra space even if the parent scrolled. Also added Adrian as a contributor, and fixed a bottom border double-up on Chrome.
Why
Make the table resize better with long lists.
What might be impacted
Todo:
📦 Published PR as canary version:
1.1.3-canary.23.465.0
✨ Test out this PR locally via:
npm install @devtools-ds/console@1.1.3-canary.23.465.0 npm install @devtools-ds/dom-inspector@1.1.3-canary.23.465.0 npm install @devtools-ds/diagnostic@1.1.3-canary.23.465.0 npm install @devtools-ds/icon@1.1.3-canary.23.465.0 npm install @devtools-ds/navigation@1.1.3-canary.23.465.0 npm install @devtools-ds/node@1.1.3-canary.23.465.0 npm install @devtools-ds/object-inspector@1.1.3-canary.23.465.0 npm install @devtools-ds/table@1.1.3-canary.23.465.0 npm install @devtools-ds/tree@1.1.3-canary.23.465.0 npm install @devtools-ds/create@1.1.3-canary.23.465.0 npm install @devtools-ds/docs@1.1.3-canary.23.465.0 npm install @devtools-ds/object-parser@1.1.3-canary.23.465.0 npm install @devtools-ds/port-controller@1.1.3-canary.23.465.0 npm install @devtools-ds/storybook-theme-addon@1.1.3-canary.23.465.0 npm install @devtools-ds/storybook-utils@1.1.3-canary.23.465.0 npm install @devtools-ds/themes@1.1.3-canary.23.465.0 # or yarn add @devtools-ds/console@1.1.3-canary.23.465.0 yarn add @devtools-ds/dom-inspector@1.1.3-canary.23.465.0 yarn add @devtools-ds/diagnostic@1.1.3-canary.23.465.0 yarn add @devtools-ds/icon@1.1.3-canary.23.465.0 yarn add @devtools-ds/navigation@1.1.3-canary.23.465.0 yarn add @devtools-ds/node@1.1.3-canary.23.465.0 yarn add @devtools-ds/object-inspector@1.1.3-canary.23.465.0 yarn add @devtools-ds/table@1.1.3-canary.23.465.0 yarn add @devtools-ds/tree@1.1.3-canary.23.465.0 yarn add @devtools-ds/create@1.1.3-canary.23.465.0 yarn add @devtools-ds/docs@1.1.3-canary.23.465.0 yarn add @devtools-ds/object-parser@1.1.3-canary.23.465.0 yarn add @devtools-ds/port-controller@1.1.3-canary.23.465.0 yarn add @devtools-ds/storybook-theme-addon@1.1.3-canary.23.465.0 yarn add @devtools-ds/storybook-utils@1.1.3-canary.23.465.0 yarn add @devtools-ds/themes@1.1.3-canary.23.465.0