Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow one theme to extend from another #42

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Allow one theme to extend from another #42

merged 4 commits into from
Dec 14, 2020

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Dec 14, 2020 •
edited
Loading

What Changed

See title

Why

A lot of themes can be expressed as sub themes

Todo:

  • Add tests
  • Add docs

Published PR with canary version: 2.3.0-canary.42.534

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Dec 14, 2020
@hipstersmoothie hipstersmoothie changed the title Allow one theme to extends from another Allow one theme to extend from another Dec 14, 2020
tylerkrupicka
tylerkrupicka approved these changes Dec 14, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@hipstersmoothie hipstersmoothie merged commit b254009 into master Dec 14, 2020
@hipstersmoothie hipstersmoothie deleted the extension branch December 14, 2020 21:25
@hipstersmoothie
Copy link
Contributor Author

🚀 PR was released in v2.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerkrupicka tylerkrupicka tylerkrupicka approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hipstersmoothie @tylerkrupicka