Added missing bigAdd function

invariant-labs · Apr 4, 2024 · 5372418 · 5372418
1 parent 8168467
commit 5372418
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/contracts/math/clamm.ral b/contracts/math/clamm.ral
@@ -112,9 +112,9 @@ Contract CLAMM(
         if (roundingUp) {
             let denominator = mul(sqrtPriceA, sqrtPriceB, SqrtPriceScale)
             let mut deltaXUp = uints.bigMul512(nominator, one(SqrtPriceScale))
-            deltaXUp = uints.bigAdd512(deltaXUp, uints.toU512(denominator - 1)) 
+            deltaXUp = uints.bigAdd(deltaXUp, denominator - 1) 
             deltaXUp = uints.bigDiv512(deltaXUp, denominator, 1)
-            deltaXUp = uints.bigAdd512(deltaXUp, uints.toU512(almostOne(SqrtPriceScale))) 
+            deltaXUp = uints.bigAdd(deltaXUp, almostOne(SqrtPriceScale)) 
             deltaXUp = uints.bigDiv512(deltaXUp, one(SqrtPriceScale), 1)
             return uints.toU256(deltaXUp)
         } else {

diff --git a/contracts/math/uints.ral b/contracts/math/uints.ral
@@ -42,6 +42,12 @@ Contract Uints () {
         }
     }
 
+    pub fn bigAdd(a: U512, b: U256) -> U512 {
+        let (lower, overflow) = overflowingAdd(a.lower, b)
+        let higher = wrappingAdd(a.higher, overflow)
+        return U512 { lower: lower, higher: higher }
+    }
+
     pub fn bigAdd512(a: U512, b: U512) -> U512 {
         let (aLowerBLower, overflow) = overflowingAdd(a.lower, b.lower)
         let aHigherBHigherOverflow = wrappingAdd(wrappingAdd(a.higher, b.higher), overflow)