An attempt at rewriting simple imputation methods as iterators #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be immediately closing this PR, but I figured I'd document why rewriting even the simple imputation methods as iterators didn't seem reasonable in the end.
Overall, I think a better approach moving forward will be to provide a handful of methods/utilities on a small selection of types that can be applied out of the box at the cost of making multiple passes. We can also focus on making the Imputor API more extensible to help get folks up and running if they think they can impute all of their data in a single pass.