-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Multi-interval set operators" #191
Conversation
This reverts commit d9923d8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant comment for reversion #179 (comment)
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 84.63% 81.73% -2.91%
==========================================
Files 12 11 -1
Lines 794 624 -170
==========================================
- Hits 672 510 -162
+ Misses 122 114 -8
Continue to review full report at Codecov.
|
FYI the proper way to have handled this would have been to yank version 1.7.0 from the General registry instead of making a 1.7.1 release |
That's what I thought, but @oxinabox said that yanking releases is typically only done for security or compat issues. Honestly, yanking releases appears to be an undocumented black art that I'm happy to avoid :) |
Definitely could be documented better. As the 1.7.0 release is still available it could still be used and break our semver requirements. I can yank 1.7.0 if that sounds good to you. In the future I suggest using yanking for this kind of rollback. |
No more or less than any other release that is not the final patch release. |
Reverts #179