Compat

[iamed2]

Removed deps, so this will require a minor version bump

This should work on 0.7 now yay

[iamed2]

Requires JuliaLang/Compat.jl#490

[iamed2]

What's with the tests passing but Travis saying they failed?

Update: it was JuliaIO/Suppressor.jl#18

[iamed2]

Can reproduce locally. There's some weird stuff going on.

[codecov]

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         225    267   +42     
=====================================
+ Hits          225    267   +42

Impacted Files	Coverage Δ
src/Memento.jl	100% <ø> (ø)	⬆️
src/records.jl	100% <ø> (ø)	⬆️
src/syslog.jl	100% <100%> (ø)
src/loggers.jl	100% <100%> (ø)	⬆️
src/handlers.jl	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57069ca...3e13a37. Read the comment docs.

[iamed2]

Alright this 0.6 test failure is weird so I say we return to this once the Syslogs METADATA PR is merged and see if that helps.

I have no idea why this happens:

WARNING: Module Syslogs with uuid 24393541116017 is missing from the cache.
This may mean module Syslogs does not support precompilation but is imported by a module that does.
ERROR: LoadError: Declaring __precompile__(false) is not allowed in files that are being precompiled.
Stacktrace:
 [1] _require(::Symbol) at ./loading.jl:455
 [2] require(::Symbol) at ./loading.jl:405
 [3] include_from_node1(::String) at ./loading.jl:576
 [4] include(::String) at ./sysimg.jl:14
 [5] anonymous at ./<missing>:2
while loading /home/travis/.julia/v0.6/Memento/src/Memento.jl, in expression starting on line 10

but it doesn't happen locally with the new Syslogs.

[rofinn]

Maybe we should add __precompile__(true) to Syslogs.jl and see what happens?

[rofinn]

I'm not a fan of having global testsets. Maybe we should switch to using TestSetExtensions.jl?

[iamed2]

Yes I'll add it in tomorrow