project: provide defaults for the allowed_copy_paths #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-moser
commented
Oct 1, 2024
| current_webpack.project.path, | ||
| current_app.static_folder, | ||
| current_app.config["WEBPACKEXT_PROJECT_DISTDIR"], |
There was a problem hiding this comment.
note: in my setup, they're basically just subdirectories of the instance_path.
if there is a chance that these could actually point to different paths, i would still keep it.
a few redundant entries in this list may look a bit weird in the average setup, but that's about it; performance won't be impacted by a so few extra entries.
ntarocco
force-pushed
the
mm/copy-to-from
branch
from
383ad5b to
3c14a53
Compare
* pynpm is already installed by pywebpack
ntarocco
force-pushed
the
mm/copy-to-from
branch
from
459c06d to
2bafa43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets some defaults for the
allowed_copy_pathsfor webpack bundle projects, based on the current Flask app.Requires inveniosoftware/pywebpack#45