Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: granular env-based solution for connection strings #2918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Nov 21, 2024

❤️ Thank you for your contribution!

Description

Partially closes: inveniosoftware/helm-invenio#112
Depends on: inveniosoftware/invenio-config#57

Questions:

Should the logic remain in this package, or should it be moved to another one e.g.: invenio_app or invenio_config and imported here?

The logic is been moved to invenio-config: inveniosoftware/invenio-config#57

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 requested a review from Copilot November 21, 2024 00:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

@Samk13 Samk13 marked this pull request as ready for review November 22, 2024 10:46
@egabancho
Copy link
Member

Hey @Samk13, would this be better inside Invenio-Config?
I think that other "apps", such as Invenio App ILS , might benefit from this improvement.

@Samk13
Copy link
Member Author

Samk13 commented Nov 26, 2024

Hey @Samk13, would this be better inside Invenio-Config? I think that other "apps", such as Invenio App ILS , might benefit from this improvement.

@egabancho, thanks for the feedback! I raised the same question in the PR description. If the core team agrees as well, I'm happy to refactor and move the logic to Invenio-Config. 👍

@Samk13 Samk13 force-pushed the calc-connection-string branch from 5ebe7db to c4e3c53 Compare November 26, 2024 13:50
@Samk13
Copy link
Member Author

Samk13 commented Nov 26, 2024

@egabancho The logic has been moved to invenio-config:57, once merged, the tests should pass here.

@Samk13 Samk13 force-pushed the calc-connection-string branch from c4e3c53 to d12d53a Compare November 28, 2024 14:37
use invenio-config util to build connection string

partially closes: inveniosoftware/helm-invenio#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granular env-based solution for "connection string"-like config
3 participants