Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communities: config: Update static page URLs to prevent name collisions #1210

Merged

Conversation

sakshamarora1
Copy link
Contributor

Fixes: #1209

@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch from c941fae to 3a86606 Compare September 24, 2024 13:50
@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch 2 times, most recently from 0e0babc to 32661e5 Compare September 30, 2024 14:38
@sakshamarora1 sakshamarora1 changed the title communities: schema: Validate slug id to exclude reserved keywords communities: config: Update static page URLs to prevent name collisions Sep 30, 2024
@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch from 32661e5 to 6bb9c6c Compare September 30, 2024 15:01
@kpsherva
Copy link
Contributor

kpsherva commented Oct 28, 2024

latest proposal (by @slint) on how to handle the links

/communities/new ---> /communities-new
/communities/search ----> /communities-search
/communities/<slug> -> leave as is
/communities ---> leave as is

and we don't "reserve" any slugs ( I am ok with this as a solution)
ping @ntarocco, is that OK?

@sakshamarora1
Copy link
Contributor Author

Reviewed with Nico, going forward with the updated comment.

@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch from 6bb9c6c to f071b6e Compare November 4, 2024 10:34
invenio_communities/config.py Outdated Show resolved Hide resolved
Copy link
Member

@0einstein0 0einstein0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @sakshamarora1 👀

@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch from fa43030 to 5ac6411 Compare November 14, 2024 16:57
@sakshamarora1 sakshamarora1 force-pushed the feature/exclude_reserved_slugs branch from 5ac6411 to f2b8b0b Compare November 19, 2024 07:31
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the work :)

@slint slint merged commit 60e0ed1 into inveniosoftware:master Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude 'new' from available community ids / slugs
7 participants