semantic-ui: CommunitySelectionModal: Remove unused Footer component #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
approved these changes
Nov 5, 2024
0einstein0
approved these changes
Nov 7, 2024
zzacharo
reviewed
Nov 13, 2024
| @@ -17,7 +17,7 @@ export const CommunitySelectionFooter = () => { | |||
| <p> | |||
| <Trans> | |||
| Did not find a community that fits you? Upload without a community or{" "} | |||
| <a href="/communities/new">create your own.</a> | |||
| <a href="/communities-new">create your own.</a> | |||
There was a problem hiding this comment.
also all these places should be changed to utilize the config rather the hardcoded values
There was a problem hiding this comment.
It's a javascript file, I'm not sure if we are already injecting config?
sakshamarora1
force-pushed
the
fix/communties-new
branch
from
ce84141 to
d6eeeb8
Compare
sakshamarora1
changed the title
zzacharo
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: inveniosoftware/invenio-communities#1209