Refactor states/status #4857
Merged
Refactor states/status #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SchrodingersGat this would be ready for a review. I moved the database additions to a new PR as this one is becoming big and hard to review with the database components intertwined. |
|
@matmair looking now, sorry I didn't respond to your previous ping. |
SchrodingersGat
approved these changes
Jun 5, 2023
InvenTree/order/migrations/0096_alter_returnorderlineitem_outcome.py
Outdated
Show resolved
Hide resolved
|
Does this trick also work with now autogenerated new migrations or is there some manual adjustment needed afterwards before committing the migration files? |
|
If you change the method used for choices you will have to adjust it again. |
- Add custom migration class which handles errors
- Ensure that the new fields are added to the model
…t/InvenTree into refactor-states
…refactor-states
|
Hopefully the upstream fixes make the CI go through now |
|
@SchrodingersGat this would be ready for review and merge |
|
@matmair ok something screwy is going on:
Looks like we need to give this one some serious attention! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for generic StatusCode definition. The goal is to make the code self-sufficient, 100% covered by unit tests and easy to use in any place needed (including plugins).
Specific changes: