-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added required attribute to settings/plugins, refactor: allValues #5224
Added required attribute to settings/plugins, refactor: allValues #5224
Conversation
- added 'required' attribute to InvenTreeBaseSetting - added 'check_all_settings' - added 'all_settings' to get a list of all defined settings - refactored 'allValues' to use new 'all_settings' function - added docs for new 'check_setting' function on plugin SettingsMixin
Seems like the coveralls reporter broke due to some permissions. My last PR used v0.5.2 and it uploaded fine, also the last run with v0.6.0 from matmair worked. They changed to use a gzip algorithm between these changes. Would needed it this time actually to add some tests to cover the new updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Coveralls does that from times to times, maybe try rerunning the action in a few hours. Their CI failing is a constituent joke around python devs. |
This PR would be ready from my POV for review. (it also increases the coverage +0.04%) |
Looks good, thanks @wolflu05 |
Needed for #4824 and also pretty handy for current plugins.
required
attribute toInvenTreeBaseSetting
check_all_settings
all_settings
to get a dict of all defined settings including theInvenTreeBaseSetting
objectallValues
to use newall_settings
functioncheck_settings
function on pluginSettingsMixin