Added required attribute to settings/plugins, refactor: allValues #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added 'required' attribute to InvenTreeBaseSetting - added 'check_all_settings' - added 'all_settings' to get a list of all defined settings - refactored 'allValues' to use new 'all_settings' function - added docs for new 'check_setting' function on plugin SettingsMixin
wolflu05
added
enhancement
|
Seems like the coveralls reporter broke due to some permissions. My last PR used v0.5.2 and it uploaded fine, also the last run with v0.6.0 from matmair worked. They changed to use a gzip algorithm between these changes. Would needed it this time actually to add some tests to cover the new updates. |
|
Coveralls does that from times to times, maybe try rerunning the action in a few hours. Their CI failing is a constituent joke around python devs. |
4 tasks
|
This PR would be ready from my POV for review. (it also increases the coverage +0.04%) |
|
Looks good, thanks @wolflu05 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #4824 and also pretty handy for current plugins.
requiredattribute toInvenTreeBaseSettingcheck_all_settingsall_settingsto get a dict of all defined settings including theInvenTreeBaseSettingobjectallValuesto use newall_settingsfunctioncheck_settingsfunction on pluginSettingsMixin