Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code structure refactor #5582

Merged
merged 105 commits into from
Apr 3, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 21, 2023

This PR implements #5578 and reorganises the code base more scalable. This is the first PR in a string of PRs needed, see #5578.

  • move container things into contrib/docker
  • move Django stuff into src/backend
  • add docs about structure to CONTRIBUTING
  • move misc things out
  • test docker build
  • test package build
  • update docs for bare metal git install

closes #5578

Breaking Change

This is a significant breaking change as it rearranges a lot of source files. Any developers who are using the devcontainer setup will need to do a complete rebuild (without cache) of the devcontainer.

@matmair matmair added docker Docker / docker-compose setup Relates to the InvenTree setup / installation process breaking Indicates a major update or change which breaks compatibility refactor labels Sep 21, 2023
@matmair matmair added this to the 1.0.0 milestone Sep 21, 2023
@matmair matmair self-assigned this Sep 21, 2023
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1e320d0
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/660c51ad382fe40008ad893c

@matmair
Copy link
Member Author

matmair commented Sep 21, 2023

@SchrodingersGat I can not find any usage of these CI checks:

  • check_api_endpoint
  • check_locale_files
    any idea why?

@SchrodingersGat
Copy link
Member

@SchrodingersGat I can not find any usage of these CI checks:

  • check_api_endpoint
  • check_locale_files
    any idea why?

These are both outdated now:

  • check_api_endpoint is now handled by invoke wait
  • check_locale_files is now defunct since moving to crowdin

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Sep 26, 2023

@matmair in general this looks OK - what still to do? Any additional unit tests we would need to add?

@matmair
Copy link
Member Author

matmair commented Sep 27, 2023

@SchrodingersGat not really, I still need to add docs - should be good to go end of week.

@SchrodingersGat
Copy link
Member

@matmair I have made some tweaks so that the devcontainer works again

@matmair
Copy link
Member Author

matmair commented Apr 2, 2024

Ok this seems to work with docker and devcontainer - the documentation issues are because of the already adapted github source links. Happy for another review; this has been very long running so not sure if I have missed something. Thank you for the help @SchrodingersGat

@SchrodingersGat
Copy link
Member

Do we need to keep the empty requirements.txt in the top level directory?

@matmair
Copy link
Member Author

matmair commented Apr 2, 2024

In my tests the packaging mechanism stopped detecting that the project uses python if I removed it.

@SchrodingersGat
Copy link
Member

@matmair I have reviewed locally again and it all seems to be working well. I will merge this in, however we should all be on the lookout for any issues stemming from this. This is a huge change to the codebase so there may well be problems.

The 0.15.x release target is for the end of the month, so let's take care until then.

@SchrodingersGat SchrodingersGat merged commit 0bace3f into inventree:master Apr 3, 2024
19 of 22 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue5578 branch April 3, 2024 01:17
@matmair
Copy link
Member Author

matmair commented Apr 3, 2024

@SchrodingersGat I expect some small surprises but most bases should be covered with the CI tests

@matmair matmair modified the milestones: 1.0.0, 0.15.0 Apr 3, 2024
This was referenced Apr 3, 2024
wolflu05 added a commit to wolflu05/inventree-bulk-plugin that referenced this pull request Apr 6, 2024
* fix tests after code structure refactor of the inventree source (related to inventree/InvenTree#5582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility docker Docker / docker-compose refactor setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Restructure code
2 participants