-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/location types #5588
Feature/location types #5588
Conversation
✅ Deploy Preview for inventree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This would be ready from my POV. The CI issues are as far as I see related to the exchange host api which currently is not working, see Formicka/exchangerate.host#236 |
|
If you look at other test runs from other branches, you can see that the recursion error is present there too in combination with the two exchange rate tests that are failing. |
@wolflu05 this looks great, thanks for taking the time to implement this, I think it is a very clean implementation :) |
This PR implements the basic functionality of StockLocation types like proposed in #5561 .
I'm not sure how far PUI is, but as far as I see, there is currently nothing where I could implement this, so it can be done when implementing the stock location forms and settings.
To keep backwards compatibility I renamed the model field (but kept the db field named
icon
) tocustom_icon
and added a setter / getter approach to the icon field. But there is one drawback with this setter, if theicon
field gets loaded as default value by any form which is later saved, the location no longer inherits its icon from the location type, because the icon is now saved to the location. Let me know if I should remove the setter or if you have a better idea.Todo
fixes #5561