CUI dependent/nested fields #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
|
@wolflu05 thanks for the updates, it appears to work well now, with existing forms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry that my old code #5837, #5913 broke the forms. I really thought I checked it enough, but it appears otherwise. The was just one single issue with the code for forms that were using the old nested field implementation with the
__. My plan was to now support both instead of refactoring all of them. The issue was that when using the old implementation the OPTIONS request returns anested objectfield, but the field data doesn't contain it and that's whyoptionsFieldis undefined in L500. I thought that trying the part form is enough, but apparently it wasn't using any of those nested fields, only if I would have tried the duplicate part form. This PR includes the old code including the fix for this undefined problem. I now tested a bunch of other forms and they worked, hopefully all work now.