Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for update_pricing method: #7075

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix for update_pricing method: #7075

merged 1 commit into from
Apr 22, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat
Fix for update_pricing method:
6d63a98 
- Specify currency
- Handle case where quantity is zero
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed order Related to purchase orders / sales orders pricing Pricing functionality backport Apply this label to a PR to enable auto-backport action backport-to-0.14.x labels Apr 22, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 22, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 22, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 6d63a98
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6625d727252ae300080cc4dd

@SchrodingersGat SchrodingersGat mentioned this pull request Apr 22, 2024
Closed
3 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (9a16a73) to head (6d63a98).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7075      +/-   ##
==========================================
- Coverage   83.24%   83.24%   -0.01%     
==========================================
  Files        1038     1038              
  Lines       45493    45493              
  Branches     1244     1244              
==========================================
- Hits        37870    37869       -1     
- Misses       7376     7377       +1     
  Partials      247      247
Flag Coverage Δ
backend 85.44% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 50ca493 into inventree:master Apr 22, 2024
33 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 22, 2024
@SchrodingersGat
Fix for update_pricing method: (#7075)
0d7f60f 
- Specify currency
- Handle case where quantity is zero

(cherry picked from commit 50ca493)
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.14.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@SchrodingersGat SchrodingersGat deleted the unit-price-fix branch April 22, 2024 03:58
SchrodingersGat added a commit that referenced this pull request Apr 22, 2024
@github-actions @SchrodingersGat
Fix for update_pricing method: (#7075) (#7076)
9869a35 
- Specify currency
- Handle case where quantity is zero

(cherry picked from commit 50ca493)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed order Related to purchase orders / sales orders pricing Pricing functionality
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat