Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log failed task #8333

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Oct 22, 2024

  • Notify staff users when a background task fails
  • Useful for visibility on failed tasks (which can occur, but hard to discover)

TODO

  • Get it working properly (currently throwing an inscrutable warning but not logging)
  • Unit testing

@SchrodingersGat SchrodingersGat added the enhancement This is an suggested enhancement or new feature label Oct 22, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 3753a75
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/671a1e26d4c87600086eb6db

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (3284727) to head (3753a75).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/models.py 80.00% 6 Missing ⚠️
src/backend/InvenTree/common/serializers.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8333      +/-   ##
==========================================
- Coverage   84.33%   84.23%   -0.11%     
==========================================
  Files        1166     1166              
  Lines       52980    52992      +12     
  Branches     1946     1934      -12     
==========================================
- Hits        44682    44637      -45     
- Misses       7813     7874      +61     
+ Partials      485      481       -4     
Flag Coverage Δ
backend 85.90% <85.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 662cf7d into inventree:master Oct 24, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the log-failed-task branch October 24, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant