Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all dependencies exept typescipt #1531

Merged
merged 11 commits into from
Oct 15, 2023
Merged

Conversation

PodaruDragos
Copy link
Contributor

@PodaruDragos PodaruDragos commented Sep 13, 2023

Tested on node 20 locally

  • test are running
  • builds are running

green to go

@PodaruDragos
Copy link
Contributor Author

PodaruDragos commented Sep 13, 2023

this should be tried after @Jameskmonger merges his CI to node 18-20.
I will eventually try to update typescript to latest but that will come after.

Anyone interested of porting the tests to jest and puppeteer ?

@Jameskmonger
Copy link
Member

@PodaruDragos I'm not sure why CI is not running against this branch .. any idea?

@Jameskmonger Jameskmonger marked this pull request as draft September 22, 2023 21:43
@Jameskmonger Jameskmonger marked this pull request as ready for review September 22, 2023 21:43
@codecov-commenter
Copy link

Codecov Report

Merging #1531 (0a28df7) into master (f956c08) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   99.56%   99.61%   +0.05%     
==========================================
  Files          53       53              
  Lines        1364     1567     +203     
  Branches      196      205       +9     
==========================================
+ Hits         1358     1561     +203     
  Partials        6        6              

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Jameskmonger Jameskmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged my changes from master in, there were some extra changes in this PR (from commit 635fae4) I reverted them for now just to make things cleaner

will raise another PR to alphabetise this @PodaruDragos

@Jameskmonger Jameskmonger merged commit dcaeda4 into master Oct 15, 2023
9 checks passed
@Jameskmonger Jameskmonger deleted the chore/update-dependencies branch October 15, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants