Skip to content

Commit

Permalink
fix(android): add guava transitive dep to module deps
Browse files Browse the repository at this point in the history
without this dep in the module build.gradle the transitive dep
was absent in to the module so module users crashed on startup

also adopt guava 33.3.1 (current) vs 31.1
  • Loading branch information
mikehardy committed Oct 7, 2024
1 parent ca4572a commit 1e88528
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ dependencies {
api 'androidx.work:work-runtime:2.8.0' // https://developer.android.com/jetpack/androidx/releases/work
api 'com.facebook.fresco:fresco:2.6.0' // https://github.com/facebook/fresco/releases

implementation("com.google.guava:guava:31.1-android") // https://github.com/google/guava
implementation("com.google.guava:guava:33.3.1-android") // https://github.com/google/guava
implementation 'androidx.core:core:1.6.0'

def room_version = '2.5.0' // https://developer.android.com/jetpack/androidx/releases/room
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ dependencies {
} else {
implementation(group: 'app.notifee', name:'core', version: '+')
}

implementation("com.google.guava:guava:33.3.1-android") // https://github.com/google/guava
implementation 'androidx.concurrent:concurrent-futures:1.1.0' // https://developer.android.com/jetpack/androidx/releases/concurrent
implementation 'androidx.work:work-runtime:2.8.0' // https://developer.android.com/jetpack/androidx/releases/work
implementation 'org.greenrobot:eventbus:3.3.1' // https://github.com/greenrobot/EventBus/releases
Expand Down

0 comments on commit 1e88528

Please sign in to comment.