docs: Update installation.md #946
Conversation
This step isn't required anymore
|
|
|
You guys should also delete the part about needing to use a Java JDK 11 image when building with EAS. At this point the default image they use is way past 11. |
| @@ -66,24 +66,6 @@ If, however, you're currently compiling your app for SDK version lower than 33, | |||
|
|
|||
| `npx expo install expo-build-properties` | |||
|
|
|||
| Then, add `@notifee/react-native` to the list of plugins in your app's Expo config (`app.json` or `app.config.js`): | |||
There was a problem hiding this comment.
you just need to replace @notifee/react-native by expo-build-properties
Then, add
expo-build-propertiesto the list of plugins in your app's Expo config (app.jsonorapp.config.js):
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
This feels really bad that even a simple adjustment to the docs can't get merged in. The way the docs are now, a lot of people are going to bounce on the installation because it's not documented correctly. I can't think of a more surefire way to kill a project then to have half the people who try to install it give up because the docs don't explain it right. |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Keep it ! |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Keep it ! |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Erm.. Could we get someone to review this? |
This step isn't required anymore and provokes a bug in compilation.