Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): prevent duplicate uniqueId for ReceiverService #957

Closed
wants to merge 1 commit into from

Conversation

hibinoA
Copy link

@hibinoA hibinoA commented Jan 11, 2024

Fixes #637 #651

This PR fills in the missing pieces of #717
#717 has made unique id for NotificationPendingIntent. This PR will make unique id also for ReceiverService with same way.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Feb 8, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Feb 8, 2024
@github-actions github-actions bot closed this Feb 23, 2024
@fobos531
Copy link
Contributor

fobos531 commented Apr 4, 2024

Hello @mikehardy

It seems like these and a couple of other PRs got closed due to inactivity. Are there plans to sift through this repository and merge such PRs? I know that this project has been in kind of a limbo recently, so I would like to base my future project decisions on whether to use it in my projects based on Invertase's commitments to this library. I am aware of that as per #899 the consensus is that the library still gets attention, but aside from a release in autumn of 2023 it hasn't come across as such.

I know that life gets in the way and Invertase switched more to contractual work, which is perfectly fine and that always gets priority. Hope all is well on that front :) Also, I hope this doesn't come off as disrespectful or condescending, I just want to make sure everything is clear for everyone.

Thank you!

@mikehardy
Copy link
Collaborator

Hey @fobos531 👋 - I see you working to keep some items in here alive, it's appreciated

It seems like these and a couple of other PRs got closed due to inactivity

Indeed, it is extraordinarily frustrating for me as maintainer-in-title-currently, I can't imagine how frustrating it is for folks interested in the repo

Are there plans to sift through this repository and merge such PRs?

Yes. I plan to do a pass here where I revive the example app (for QA for me), the release process (it's partially manual which is a real blocker for me), the documentation (hasn't been published in forever, we're close to having a fix here) and then with that opening up the pipeline for ingesting change, start merging pending PRs

I know that this project has been in kind of a limbo recently, so I would like to base my future project decisions on whether to use it in my projects based on Invertase's commitments to this library.

Totally reasonable - for the avoidance of doubt Invertase is committed, and through no fault of their own they asked me if I had time which I did when they asked, then after they asked my time was consumed up until now. I just want to state that openly because Invertase has always treated me excellently, and they do a great service to the community by investing in this library at their own expense. The delay is all mine.

However, I've got some time to work on it blocked off for near future and I hope to make good on the commitment I made to Invertase and to all you users here by getting this going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants