Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for VisionOS #352

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

j6alvarez
Copy link
Contributor

@j6alvarez j6alvarez commented Sep 13, 2024

I have been doing some work with this repo https://github.com/callstack/react-native-visionos

And wanted to contribute sharing what made it work for me following the instructions in this post

This allows to run appleAuth methods for react-native-visionos

Fixes #350

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

@j6alvarez j6alvarez changed the title Support for VisionOS feat: support for VisionOS Sep 13, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, the only imaginable way it could fail is if the UIKit import isn't available on other platforms, but I just scanned other repos I maintained and I don't see them IFDEF'ing the UIKit.h import even though I'm certain they build on macCatalyst at least, and I believe macos even.

Either way, that's easy to fix either. Happy to merge this for visionOS support now

@mikehardy mikehardy merged commit 975b7d0 into invertase:main Sep 13, 2024
8 checks passed
@mikehardy
Copy link
Collaborator

😆 indeed when I ran yarn example:macos what I feared happened - the build was broken for macOS because of the UIKit.h inclusion. I swear I had seen that somewhere but also I checked and couldn't find it.

Anyway, one quick change later and it's good

#if TARGET_OS_IPHONE
#import <UIKit/UIKit.h>
#endif

@j6alvarez
Copy link
Contributor Author

Uh nice that you fixed it easily, I haven't use the library for macOS, just for visionOS and iOS. Thanks for fixing this 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for VisionOS
3 participants