Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all, android): purge jcenter() from android build #5195

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Only remaining jcenter usage is in our tests app, not used by
library consumers, where we must retain it until react-native itself
is jcenter-free

Also bumped everything in the template to current and bumped kotlin in tests app to 1.4.32 from 1.4.31 but no one will notice or care ;-)

Related issues

Tracking remaining usage: react-native-community/releases#221 (comment)

Release Summary

It's a conventional commit message

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I ran yarn tests:build:test to make sure everything still built after. It still builds, unless you comment out the final jcenter line, then it fails on known problems (link above).


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Only remaining jcenter usage is in our tests app, not used by
library consumers, where we must retain it until react-native itself
is jcenter-free
@vercel
Copy link

vercel bot commented Apr 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/Hio5tANkYZBzTZsKZfro4Ky5ik1f
✅ Preview: https://react-native-firebase-git-mikehardy-purge-jcenter-invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@ca68518). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a3bc297 differs from pull request most recent head ce47d4f. Consider uploading reports for the commit ce47d4f to get more accurate results

@@            Coverage Diff            @@
##             master    #5195   +/-   ##
=========================================
  Coverage          ?   88.87%           
=========================================
  Files             ?      109           
  Lines             ?     3744           
  Branches          ?      360           
=========================================
  Hits              ?     3327           
  Misses            ?      370           
  Partials          ?       47           

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 19, 2021
@mikehardy mikehardy merged commit 2c6a6a8 into master Apr 19, 2021
@mikehardy mikehardy deleted the @mikehardy/purge-jcenter branch April 19, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant