Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): bump SDKs: firebase-android-sdk 28.1.0 / firebase-ios-sdk 8.1.1 #5412

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

  • fix up a spelling dictionary lint thing
  • bump SDK versions, especially for firebase-ios-sdk 8.1.1 to avoid app store rejections

Related issues

firebase/firebase-ios-sdk#8222

Release Summary

conventional commits, should result in v12.1.0 here

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Passed e2e testing on local device, should pass CI as well


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BQ54QrpiArE6K7LCYWfHTFqM94VU
✅ Preview: https://react-native-firebase-git-mikehardy-dependency-310d7b-invertase.vercel.app

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #5412 (4fd320c) into master (3fef777) will decrease coverage by 51.78%.
The diff coverage is n/a.

❗ Current head 4fd320c differs from pull request most recent head 426a45c. Consider uploading reports for the commit 426a45c to get more accurate results

@@             Coverage Diff             @@
##           master    #5412       +/-   ##
===========================================
- Coverage   74.56%   22.78%   -51.77%     
===========================================
  Files          96       82       -14     
  Lines        4287     3877      -410     
  Branches      921      921               
===========================================
- Hits         3196      883     -2313     
- Misses       1021     2411     +1390     
- Partials       70      583      +513     

@mikehardy mikehardy changed the title feat(app): bump SDKs: firebase-android-sdk 28.1.0 / firebase-ios-sdk 8.1.1 feat(app): bump SDKs: firebase-android-sdk 28.1.0 / firebase-ios-sdk 8.1.1 Jun 11, 2021
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 5273aea to 426a45c Compare June 11, 2021 21:21
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jun 11, 2021
@mikehardy mikehardy merged commit ba41209 into master Jun 11, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 11, 2021
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch June 15, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant