-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth, android): linkWithCredential will not attempt to upgrade from anon user (matches iOS) #5694
Conversation
Description When doing "linkWithCredential" in Android and the users exists relogin with this new user instead of launch exception Error: [auth/credential-already-in-use] This credential is already associated with a different user account. Related issues
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DpJztSP8sKvUAkEqMnE9EeKADFag react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/587vAasLKcwRcNzZZH6uj5ezJUwV |
Codecov Report
@@ Coverage Diff @@
## master #5694 +/- ##
============================================
+ Coverage 53.63% 53.73% +0.11%
Complexity 632 632
============================================
Files 208 208
Lines 10085 10069 -16
Branches 1543 1542 -1
============================================
+ Hits 5408 5410 +2
+ Misses 4393 4375 -18
Partials 284 284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for posting this! I went to the relevant PR #4487 and PR #4552 and per a comment there:
the original author has actually disavowed this style as well, with an indication it was no longer working anyway, so this looks like a good PR. Shame the style doesn't work - it would be a nicer DX if it did work and we could do the same thing in iOS but it is best if the platforms are consistent, and if this isn't working it should be removed
Thanks for the PR!
Description
When doing "linkWithCredential" in Android and the users exists, it makes relogin with this new user instead of launch exception:
Error: [auth/credential-already-in-use] This credential is already associated with a different user account.
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter