Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_waypoints_state method to the simulator and visualize all waypoints when recording birdviews #41

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

lioutasb
Copy link
Member

No description provided.

@lioutasb lioutasb requested a review from adscib March 19, 2024 00:44
@adscib
Copy link
Contributor

adscib commented Mar 22, 2024

Can you explain how this works with instances of NPCWrapper? Do you return waypoints for all agents, including the hidden ones? If so, what's the mechanism for matching them to the exposed agents?

@lioutasb
Copy link
Member Author

lioutasb commented Mar 22, 2024

Waypoints are defined at the creation of the base simulator object. This means that waypoints (appropriately masked) must be given for all possible agents and agent types. The methods that return waypoint states, masks, etc follow the implementation and interface similar to the get_state() method on the various wrappers that restrict the agent dimension based on which agents are exposed. Similarly for the homogeneous wrapper that concatenates everything.

@lioutasb lioutasb merged commit 6e324aa into master Mar 22, 2024
4 checks passed
@lioutasb lioutasb deleted the update_simulator branch March 22, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants