Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuronavigation GUI revamp #643

Merged
merged 109 commits into from
Aug 18, 2023

Conversation

mahansh564
Copy link
Collaborator

@mahansh564 mahansh564 commented Aug 11, 2023

Overhaul of Invesalius UI
I have resolved possible conflicts but some more testing is recommended.

Some major changes for current developers:

  1. E-Field has been moved from task_navigator.py to task_efield.py for semantic reasons.
  2. Tractography has been moved from task_navigator.py to task_tractography for semantic reasons.
  3. Important legacy code can be found at the end of the file in a comment.

Attempts to fix #378 #592 #506 #298 #594 #595 #599

@sotodela sotodela added enhancement neuronavigation Issues related to neuronavigation software ui/ux Bug or enhancement related to user interface and user experience labels Aug 17, 2023
@mahansh564
Copy link
Collaborator Author

I have just one final suggestion, similar to the pull request #634, the "Show coil" could be enabled when the navigation is on too.

Fixed!

@rmatsuda
Copy link
Collaborator

rmatsuda commented Aug 17, 2023

Many thanks, @mahansh564! I just found an issue, sorry I have two more suggestions. When changing an invesalius project, the fiducials, both image and tracker, are not resetting. And the stimulator is been removed, although, the stimulator can be kept between inv projects. The second suggestion is related to the Data lower fold panel. For the mode without navigation its starting collapsed, I think it should be as before, collapsed=False

@mahansh564
Copy link
Collaborator Author

mahansh564 commented Aug 17, 2023

Many thanks, @mahansh564! I just found an issue, sorry I have two more suggestions. When changing an invesalius project, the fiducials, both image and tracker, are not resetting. And the stimulator is been removed, although, the stimulator can be kept between inv projects. The second suggestion is related to the Data lower fold panel. For the mode without navigation its starting collapsed, I think it should be as before, collapsed=False

Fixed the first one! Not sure that I understand the second one. It is currently starting with the data panel not visible. Should it be visible? I had changed it because when project is not loaded the data tab just shows empty columns if it is collapsed

@rmatsuda
Copy link
Collaborator

I open one invesalius project, then I clicked to open another project and didnt removed the 3D objects from the previous project.
image

@rmatsuda
Copy link
Collaborator

The tracker fiducials need to be reset as well. Change a invesalius project means to change a patient (volunteer). And the tracker fiducials need to be changed.
image

@mahansh564
Copy link
Collaborator Author

I open one invesalius project, then I clicked to open another project and didnt removed the 3D objects from the previous project. image

I'll look at this tomorrow in the lab but my laptop doesn't seem to have the problem.

@mahansh564
Copy link
Collaborator Author

mahansh564 commented Aug 17, 2023

The tracker fiducials need to be reset as well. Change a invesalius project means to change a patient (volunteer). And the tracker fiducials need to be changed. image

I fixed this in the FIX: Close Project fixes. Does it not work?

@rmatsuda
Copy link
Collaborator

The tracker fiducials need to be reset as well. Change a invesalius project means to change a patient (volunteer). And the tracker fiducials need to be changed. image

I fixed this in the FIX: Close Project fixes. Does it not work?

Now I see the problem. When I change between projects, the active tab keeps the same as the last project (last one). I think just changing to the first one (Image) will work fine.

@rmatsuda
Copy link
Collaborator

Many thanks, @mahansh564! I just found an issue, sorry I have two more suggestions. When changing an invesalius project, the fiducials, both image and tracker, are not resetting. And the stimulator is been removed, although, the stimulator can be kept between inv projects. The second suggestion is related to the Data lower fold panel. For the mode without navigation its starting collapsed, I think it should be as before, collapsed=False

Fixed the first one! Not sure that I understand the second one. It is currently starting with the data panel not visible. Should it be visible? I had changed it because when project is not loaded the data tab just shows empty columns if it is collapsed

I think is fine to keep it like that. @tfmoraes @paulojamorim Do you agree?

@mahansh564
Copy link
Collaborator Author

The tracker fiducials need to be reset as well. Change a invesalius project means to change a patient (volunteer). And the tracker fiducials need to be changed. image

I fixed this in the FIX: Close Project fixes. Does it not work?

Now I see the problem. When I change between projects, the active tab keeps the same as the last project (last one). I think just changing to the first one (Image) will work fine.

That is done in MISC: Some fixes.

@mahansh564
Copy link
Collaborator Author

mahansh564 commented Aug 18, 2023

I open one invesalius project, then I clicked to open another project and didnt removed the 3D objects from the previous project. image

I'll look at this tomorrow in the lab but my laptop doesn't seem to have the problem.

Any hints on where this problem might be? We are not facing the problem in the lab.

@rmatsuda
Copy link
Collaborator

rmatsuda commented Aug 18, 2023

I open one invesalius project, then I clicked to open another project and didnt removed the 3D objects from the previous project. image

I'll look at this tomorrow in the lab but my laptop doesn't seem to have the problem.

Any hints on where this problem might be? We are not facing the problem in the lab.

I couldn't replicate this anymore. It looks like some commit fixed it.

Thanks again for the impressive work, @mahansh564! Thats a very good improvement for neuronavigation.
I have no more comments about the GUI.

@mahansh564
Copy link
Collaborator Author

I open one invesalius project, then I clicked to open another project and didnt removed the 3D objects from the previous project. image

I'll look at this tomorrow in the lab but my laptop doesn't seem to have the problem.

Any hints on where this problem might be? We are not facing the problem in the lab.

I couldn't replicate this anymore. It looks like some commit fixed it.

Thanks again for the impressive work, @mahansh564! Thats a very good improvement for neuronavigation. I have no more comments about the GUI.

Thank you @rmatsuda!

@vhosouza
Copy link
Member

vhosouza commented Aug 18, 2023

Extensively tested by me and @rmatsuda. This PR makes a major change to the UI and controls associated with the neuronavigation, the robot control, the tractography and targeting visualization.

This can potentially break compatibility with previous projects and ongoing branches and needs to be tested further.

Thank you for the extensive and amazing work @mahansh564!

@vhosouza vhosouza merged commit a529d94 into invesalius:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement neuronavigation Issues related to neuronavigation software ui/ux Bug or enhancement related to user interface and user experience
Projects
None yet
6 participants