-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuronavigation GUI revamp #643
Neuronavigation GUI revamp #643
Conversation
This reverts commit e0db774.
Fixed! |
Many thanks, @mahansh564! I just found an issue, sorry I have two more suggestions. When changing an invesalius project, the fiducials, both image and tracker, are not resetting. And the stimulator is been removed, although, the stimulator can be kept between inv projects. The second suggestion is related to the Data lower fold panel. For the mode without navigation its starting collapsed, I think it should be as before, collapsed=False |
Fixed the first one! Not sure that I understand the second one. It is currently starting with the data panel not visible. Should it be visible? I had changed it because when project is not loaded the data tab just shows empty columns if it is collapsed |
I fixed this in the FIX: Close Project fixes. Does it not work? |
Now I see the problem. When I change between projects, the active tab keeps the same as the last project (last one). I think just changing to the first one (Image) will work fine. |
I think is fine to keep it like that. @tfmoraes @paulojamorim Do you agree? |
That is done in MISC: Some fixes. |
I couldn't replicate this anymore. It looks like some commit fixed it. Thanks again for the impressive work, @mahansh564! Thats a very good improvement for neuronavigation. |
Thank you @rmatsuda! |
Extensively tested by me and @rmatsuda. This PR makes a major change to the UI and controls associated with the neuronavigation, the robot control, the tractography and targeting visualization. This can potentially break compatibility with previous projects and ongoing branches and needs to be tested further. Thank you for the extensive and amazing work @mahansh564! |
Overhaul of Invesalius UI
I have resolved possible conflicts but some more testing is recommended.
Some major changes for current developers:
Attempts to fix #378 #592 #506 #298 #594 #595 #599