Add searchengine attribute structure to replace elasticsearch #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that opensearch can be used, with a switch `searchengine.platform` like how `database.platform` is used.
|
the changing of ELASTICSEARCH_* environment variables downstream will be a downstream problem to solve |
kierenevans
reviewed
Dec 14, 2023
Co-authored-by: Kieren Evans <kierenevans@users.noreply.github.com>
|
going to hold off on this till I've tested opensearch. Both seem to user/password by default now, and I'm thinking, as managed services are also, it might be best defaulting to using that. |
|
actually I'll just adapt it as a separate PR if going that way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that opensearch can be used, with a switch
searchengine.platformlike howdatabase.platformis used.