Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split set/unset, improve newline handling #147

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

NoDiskInDriveA
Copy link
Contributor

@NoDiskInDriveA NoDiskInDriveA commented Feb 18, 2024

  • splits set and unset so ws commands can revert to attributes to default
  • unset: checks for existing attributes only at beginning of a line
  • set: inserts a newline before a new attribute unless file already ends with one

@NoDiskInDriveA NoDiskInDriveA added the enhancement New feature or request label Feb 18, 2024
@NoDiskInDriveA
Copy link
Contributor Author

FYI the use case is resetting an attribute to default. Commands like xdebug feature as of now always require setting an override value to default. Also, if your override file doesn't end in a newline, attributes written get glued to the end of the last line, that's why I added a newline check/insert.

@NoDiskInDriveA NoDiskInDriveA enabled auto-merge (squash) March 8, 2024 13:25
@NoDiskInDriveA NoDiskInDriveA merged commit ecb5185 into 0.4.x Mar 8, 2024
1 check passed
@NoDiskInDriveA NoDiskInDriveA deleted the feature/improve-attr-set-unset-commands branch March 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants