Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: app shutdown handler not being called #6242

Closed
1 task done
psychedelicious opened this issue Apr 19, 2024 · 0 comments · Fixed by #6244
Closed
1 task done

[bug]: app shutdown handler not being called #6242

psychedelicious opened this issue Apr 19, 2024 · 0 comments · Fixed by #6244
Assignees
Labels
bug Something isn't working

Comments

@psychedelicious
Copy link
Collaborator

psychedelicious commented Apr 19, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

Operating system

Linux

GPU vendor

Nvidia (CUDA)

GPU model

No response

GPU VRAM

No response

Version number

main a35386f

Browser

ff

Python dependencies

No response

What happened

The ApiDependencies.shutdown method is not called when you press ^C to stop the app. As a result, the services are unable to do their shutdown tasks like clearing the tensor outputs

What you expected to happen

The ApiDependencies.shutdown method is called when you press ^C

How to reproduce the problem

  • Add print statements to the lifespan function in api_app.py - one for startup and one for shutdown
  • Start the app, note the startup print stmt works
  • Press ^C to end the app, note no shutdown print stmt

Additional context

Introduced by #6026

Discord username

No response

@psychedelicious psychedelicious added the bug Something isn't working label Apr 19, 2024
@lstein lstein self-assigned this Apr 19, 2024
lstein pushed a commit that referenced this issue Apr 19, 2024
lstein added a commit that referenced this issue Apr 19, 2024
* closes #6242

* only override sigINT during slow model scanning

* fix ruff formatting

---------

Co-authored-by: Lincoln Stein <lstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants