-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Float64 error for mps devices on set_timesteps #4040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this on mine - 2020 M1 w/ 16GB of RAM and it is working as expected.
HUGE shoutout to @psychedelicious for the help in setting up the local dev environment
…/InvokeAI into set-timestep-mps-fix
Would like approval from @StAlKeR7779 for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With @StAlKeR7779 's help, I committed a small change that fixes the issue on Linux systems. This should be tested again on MPS systems.
|
@ZachNagengast are you in the Discord? |
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
Please test on an MPS (M1/M2) device.
Relevant code causing the error in #4017
https://github.com/huggingface/diffusers/blob/01b6ec21faf2dce3373238b12eb450030ab1f318/src/diffusers/schedulers/scheduling_euler_discrete.py#L263C3-L268C75