-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix .swap() by reverting improperly merged @classmethod change #4080
fix .swap() by reverting improperly merged @classmethod change #4080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 1.5 models, works again!
SD 1.x resultsPrompt: Prompt: Prompt: SD 2.x resultsSame as SD 1.x. |
SDXL resultsExceptions all the way. Is that in scope here or should we consider it separately? |
thanks @keturn.
i don't know what SDXL support should look like. i cannot run SDXL on my machine which makes me a poor candidate for looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging as the missing pieces ( |
What type of PR is this? (check all applicable)
brings back
.swap()
(will not work with inpainting, sequential guidance, or xformers. untested with SDXL)