Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageLerpInvocation math bug: Add self.min, not self.max #4176

Merged

Conversation

lillekemiker
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because: minor bug fix

Have you updated all relevant documentation?

  • Yes
  • No

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

@lillekemiker lillekemiker changed the title Add self.min, not self.max ImageLerpInvocation math bug: Add self.min, not self.max Aug 9, 2023
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late approval! TBH, I don't understand the math, but I do trust you on this.

@psychedelicious psychedelicious enabled auto-merge (rebase) August 9, 2023 23:52
@psychedelicious psychedelicious merged commit c8fbaf5 into invoke-ai:main Aug 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants