-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor generation backend #4201
Conversation
Co-Authored-By: Kent Keirsey <31807370+hipsterusername@users.noreply.github.com>
Can we merge #4175 first? I admit it's partly my thirst for those sweet line-deletion credits, but also there are a half-dozen different things going on in a single PR here and if we can take advantage of an already-existing PR to cut it down in scope, I think that will make it easier to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for merging in the other code removal first!
That knocked down the size of this PR a bit, but IMHO it's still too much for a single PR.
There's inpainting stuff that could be done without the SDXL stuff,
the seeding of the stochastic schedulers is an independent issue,
the changes to adjust-memory-efficient-attention could and should be considered and tested on their own--
I've left a few comments so far, but this does not constitute anything near a complete review. I haven't even got to the changes in shared_invokeai_diffusion
yet, let alone any of the SDXL.
Co-Authored-By: psychedelicious <4822129+psychedelicious@users.noreply.github.com>
Was never used for inpainting but was fed to the node anyway.
This is probably better done on the backend or in a different way. This can cause steps to go above 1000 which is more than the set number for the model.
Needed for some schedulers
Bug has been fixed. No longer needed.
This reverts commit 511da59.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Added/updated tests?