Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow symbolic links to be followed during autoimport #4268

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Aug 14, 2023

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix

Have you discussed this change with the InvokeAI team?

  • Yes

Have you updated all relevant documentation?

  • Yes

Description

Follow symbolic links when auto importing from a directory. Previously links to files worked, but links to directories weren’t entered during the scanning/import process.

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need this in other places?

@lstein
Copy link
Collaborator Author

lstein commented Aug 17, 2023

I wonder if we need this in other places?

I looked and found several other instances where os.walk() was being called without followlinks=True. I’ve updated them.

Copy link
Contributor

@GreggHelt2 GreggHelt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstein lstein merged commit 498d2ec into main Aug 18, 2023
8 checks passed
@lstein lstein deleted the bugfix/enable-links-in-autoimport branch August 18, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants