Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(diffusers): upgrade diffusers to 0.20 #4311

Merged
merged 4 commits into from
Aug 19, 2023
Merged

dep(diffusers): upgrade diffusers to 0.20 #4311

merged 4 commits into from
Aug 19, 2023

Conversation

keturn
Copy link
Contributor

@keturn keturn commented Aug 17, 2023

This allows us to work with some new stuff including TAESD: https://github.com/huggingface/diffusers/releases/tag/v0.20.0

Removed is_safetensors_available as safetensors is now a required dependency of diffusers.

What type of PR is this? (check all applicable)

  • dependency upgrade

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • no; only minimal code changes on our side, nothing new to test.

Removed `is_safetensors_available` as safetensors is now a required dependency of diffusers.
@keturn
Copy link
Contributor Author

keturn commented Aug 17, 2023

I did a quick test on Linux + xformers of generation stuff for SD 1.x, 2.x, and SDXL, and some inpainting, and that all seemed fine.

Copy link
Contributor

@GreggHelt2 GreggHelt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still code in backend/model_management/convert_ckpt_to_diffusers that uses the diffusers is_safetensors_available() method. I'm guessing those will currently break model manager when conversion to diffusers is needed.

@keturn keturn added dependencies Pull requests that update a dependency file python PRs that change python files labels Aug 18, 2023
@keturn
Copy link
Contributor Author

keturn commented Aug 18, 2023

oh, ckpts, those things. Good catch, Gregg!

I've removed those references to the function and did another search to be sure. I didn't find any is_safetensors_available left in any of the other files.

@keturn keturn requested a review from GreggHelt2 August 18, 2023 18:08
Copy link
Contributor

@GreggHelt2 GreggHelt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keturn keturn merged commit 0f1b975 into main Aug 19, 2023
8 checks passed
@keturn keturn deleted the dep/diffusers020 branch August 19, 2023 01:22
hipsterusername added a commit that referenced this pull request Sep 20, 2023
[TAESD - Tiny Autoencoder for Stable
Diffusion](https://github.com/madebyollin/taesd) - is a tiny VAE that
provides significantly better results than my single-multiplication hack
but is still very fast.

The entire TAESD model weights are under 10 MB!

This PR requires diffusers 0.20:
- [x] #4311 

## To Do

Test with
- [x] SD 1.x
- [ ] SD 2.x: #4415 
- [x] SDXL

## Have you discussed this change with the InvokeAI team?
- See [TAESD Invocation
API](https://discord.com/channels/1020123559063990373/1137857402453119166)
      
## Have you updated all relevant documentation?
- [ ] No


## Related Tickets & Documents

<!--
For pull requests that relate or close an issue, please include them
below. 

For example having the text: "closes #1234" would connect the current
pull
request to issue 1234.  And when we merge the pull request, Github will
automatically close the issue.
-->

- Related Issue #
- Closes #

## QA Instructions, Screenshots, Recordings

Should be able to import these models:
- [madebyollin/taesd](https://huggingface.co/madebyollin/taesd)
- [madebyollin/taesdxl](https://huggingface.co/madebyollin/taesdxl)

and use them as VAE.

<!-- 
Please provide steps on how to test changes, any hardware or 
software specifications as well as any other pertinent information. 
-->

## Added/updated tests?

- [x] Some. There are new tests for VaeFolderProbe based on VAE
configurations, but no tests that require the full model weights.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants