nodes phase 5: workflow saving and loading #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
Kyle0654 and
brandonrising
as code owners
blessedcoolant
requested review from
damian0815,
lstein,
GreggHelt2,
StAlKeR7779 and
RyanJDick
as code owners
was causing failure to save images
…y) to decorator All invocation metadata (type, title, tags and category) are now defined in decorators. The decorators add the `type: Literal["invocation_type"]: "invocation_type"` field to the invocation. Category is a new invocation metadata, but it is not used by the frontend just yet. - `@invocation()` decorator for invocations ```py @invocation( "sdxl_compel_prompt", title="SDXL Prompt", tags=["sdxl", "compel", "prompt"], category="conditioning", ) class SDXLCompelPromptInvocation(BaseInvocation, SDXLPromptInvocationBase): ... ``` - `@invocation_output()` decorator for invocation outputs ```py @invocation_output("clip_skip_output") class ClipSkipInvocationOutput(BaseInvocationOutput): ... ``` - update invocation docs - add category to decorator - regen frontend types
psychedelicious
requested review from
hipsterusername and
Millu
as code owners
hipsterusername
approved these changes
Aug 30, 2023
|
There's a circular dependency in the frontend code that I'm not going to get around to fixing. This can be force-merged. |
blessedcoolant
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Embed Workflowcheckbox which, if enabled, saves the workflowBaseInvocationnow has anworkflow: Optional[str]field, so all nodes automatically have the field (but again only image-outputting nodes display this in UI)workflow=self.workflowwhen they save their output image to have the workflow written to the imageTODO
Related Tickets & Documents
QA Instructions, Screenshots, Recordings