Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra steps to update the Cudnnn DLL found in the Torch packages #4459

Merged
merged 8 commits into from
Sep 7, 2023

Conversation

Keerigan45
Copy link
Contributor

@Keerigan45 Keerigan45 commented Sep 5, 2023

I added extra steps to update the Cudnnn DLL found in the Torch package because it wasn't optimised or didn't use the lastest version. So manually updating it can speed up iteration but the result might differ from each card. Exemple i passed from 3 it/s to a steady 20 it/s.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

I added extra steps to update the Cudnnn DLL found in the Torch package because it wasn't optimised or didn't use the lastest version. So manually updating it can speed up iteration but the result might differ from each card. Exemple i passed from 3 it/s to a steady 20 it/s.
@Malrama
Copy link
Contributor

Malrama commented Sep 5, 2023

Maybe also add if one should download the CUDA 11.X or CUDA 12.X version of CUDNN because that is something one is asked to choose from before downloading.
I assumed it was CUDA 11.X, am I correct?

@Keerigan45
Copy link
Contributor Author

https://docs.nvidia.com/deeplearning/cudnn/support-matrix/index.html May add this link and ask to just download the 11x version if their architecture doesn't show up. Or they can try both if they got time to see which version works better.

Copy link
Contributor

@Millu Millu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some types and updated readability, looks good to me! Once that link is added we should be good to go

Keerigan45 and others added 3 commits September 7, 2023 03:24
Added Extra step and clarification on how to choose between 11x or 12x update for Cudnnn dll
Copy link
Contributor

@Millu Millu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for adding this!

@Millu Millu merged commit a98c37b into invoke-ai:main Sep 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants