Allow in place local installs of models #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
blessedcoolant,
psychedelicious and
hipsterusername
as code owners
brandonrising
changed the title
github-actions
bot
added
api
python
|
I think the only concern I have with this is the UX. It doesn't seem to me that users will have clear visibility into where everything is, but recognize this is probably an improvement over the current state. |
hipsterusername
force-pushed
the
inplace-local-installs
branch
from
af29505
to
27092ae
Compare
psychedelicious
approved these changes
Mar 4, 2024
psychedelicious
force-pushed
the
inplace-local-installs
branch
from
27092ae
to
3b2c605
Compare
psychedelicious
force-pushed
the
inplace-local-installs
branch
from
3b2c605
to
f719ead
Compare
Yeah no need to expose this currently. I do think people would like this feature eventually though if they also use other similar tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Allow in-place installs of local models without copying them to the <INVOKE_ROOT>/models dir.
QA Instructions, Screenshots, Recordings
Merge Plan
This PR can be merged when approved
Added/updated tests?