feat(ui): model manager UI pass #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
GreggHelt2,
brandonrising and
RyanJDick
as code owners
github-actions
bot
added
python
maryhipp
approved these changes
Mar 7, 2024
hipsterusername
approved these changes
Mar 7, 2024
- Move image display to left - Move description into model header - Move model edit & convert buttons to top right of model header - Tweak styles for model display component
When we change a model image, its URL remains the same. The browser will aggressively cache the image. The easiest way to fix this is to append a random query parameter to the URL whenever we build a model config in the API.
Without this, the form will incorrectly compare its state to its initial default values to determine if it is dirty. Instead, it should reset its default values to the new values after successful submit.
This greatly reduces the number of network requests when editing models.
If we don't clear it, there's an awkward flash of error state as the mutation completes.
psychedelicious
force-pushed
the
psyche/ui/model-manager-ui
branch
from
e91200f
to
aa74c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
Numerous MM UI enhancements and fixes, see commits for details.
Notable changes:
trigger_phrases. The backend is updated accordingly.updateModelendpoint. The model images endpoints still need the same treatment, didn't get to it today.QA Instructions, Screenshots, Recordings
Take the MM tab for a spin.
Merge Plan
This PR can be merged when approved