Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code related to an old symmetry feature. #5899

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

RyanJDick
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Description

Remove dead code related to an old symmetry feature.

Note that postprocessing_settings was hard-coded to:

PostprocessingSettings(
    threshold=0.0,  # threshold,
    warmup=0.2,  # warmup,
    h_symmetry_time_pct=None,  # h_symmetry_time_pct,
    v_symmetry_time_pct=None,  # v_symmetry_time_pct,
)

This fixed configuration meant that the post-processing logic was having no effect.

QA Instructions, Screenshots, Recordings

I ran image generation with and without this change. The resultant images are identical.

Added/updated tests?

  • Yes
  • No: No tests affected.

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Mar 8, 2024
@RyanJDick RyanJDick marked this pull request as ready for review March 8, 2024 14:48
@hipsterusername hipsterusername enabled auto-merge (rebase) March 10, 2024 06:05
@hipsterusername hipsterusername merged commit 145bb45 into main Mar 10, 2024
14 checks passed
@hipsterusername hipsterusername deleted the ryan/remove-apply-symmetry branch March 10, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants