Do not override log_memory_usage when debug logs are enabled #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanJDick
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Mar 11, 2024
…ed cost of log_memory_usage=True is large. It is common to want debug log without enabling log_memory_usage.
psychedelicious
force-pushed
the
ryan/fix-log-mem-usage
branch
from
e47eb62
to
06048ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A recent change was made to force
log_memory_usage=Truewhen debug logs are enabled (commit: 67eb715). This PR reverts that change.The speed cost of log_memory_usage=True is large (as documented here: #5028). It is common to want debug logs without enabling
log_memory_usage.