feat(nodes): defaults dimensions for main models #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
GreggHelt2,
brandonrising and
RyanJDick
as code owners
github-actions
bot
added
python
maryhipp
approved these changes
Mar 12, 2024
|
The initial default width and height are derived by the model probe. |
psychedelicious
force-pushed
the
psyche/nodes/defaults-dimensions
branch
from
43e6644
to
e618f44
Compare
brandonrising
approved these changes
Mar 13, 2024
psychedelicious
force-pushed
the
psyche/nodes/defaults-dimensions
branch
from
506cf6a
to
d94367d
Compare
Currently, this is just the width and height, derived from the model base.
psychedelicious
force-pushed
the
psyche/nodes/defaults-dimensions
branch
from
d94367d
to
5de0bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add width and height to model default settings.
Merge Plan
This PR can be merged when approved